Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Change bindings try order to be PyQt5, PySide2, PyQt6, PySide6 #343

Merged
merged 1 commit into from
Apr 29, 2022
Merged

PR: Change bindings try order to be PyQt5, PySide2, PyQt6, PySide6 #343

merged 1 commit into from
Apr 29, 2022
+68 −64

Conversation

dalthviz
Copy link
Member

Fixes #342

@dalthviz dalthviz added this to the v2.1.0 milestone Apr 28, 2022
@dalthviz dalthviz self-assigned this Apr 28, 2022
@dalthviz dalthviz changed the title PR: Change bindings 'try order' to be PyQt5, PySide2, PyQt6, PySide6 PR: Change bindings try order to be PyQt5, PySide2, PyQt6, PySide6 Apr 28, 2022
ccordoba12
ccordoba12 approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit f466699 into spyder-ide:master Apr 29, 2022
@ccordoba12
Copy link
Member

Note: Please don't forget to mention this in our Changelog for 2.1.0 because it could catch people off guard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels
None yet
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

Change bindings try order to follow QtPy v1.x convention
2 participants
@dalthviz @ccordoba12